Add ignorelist to local exploit suggester datastore options #19739
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adfoster-r7
reviewed
Dec 16, 2024
| @@ -110,8 +110,9 @@ def valid_incompatibility_reasons(mod, verify_reasons) | |||
| end | |||
|
|
|||
| def set_module_options(mod) | |||
| ignore_list = ['ACTION', 'TARGET'].freeze | |||
There was a problem hiding this comment.
Context: The user setting TARGET to a value globally or locally in the datastore would unintentionally be assigned to the local exploit module that was being tested against
There was a problem hiding this comment.
ACTION isn't required with the current implementations, but just future-proofing for a future potential bug if it was wired up
adfoster-r7
approved these changes
Dec 16, 2024
Release NotesFixes an issue with the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR prevents copying of some datastore options known to cause potential issues in the local exploit suggester.
This fixes a Pro-specific crash.
Verification
msfconsolelocal_exploit_suggesteragainst the session